No blank cv/french view #991
Conversation
airgun/entities/contentview_new.py
Outdated
| view = self.navigate_to(self, 'Edit', entity_name=entity_name) | ||
| return view.versions.table.read() | ||
|
|
||
| def check_if_blank_in_french(self): |
There was a problem hiding this comment.
I would rather name this differently read_french_lang(), here you are not checking this could be part of the test.
There was a problem hiding this comment.
Yes. This is just a read in french without any assertion.
There was a problem hiding this comment.
ah yeah, that does make more sense. good suggestion!
There was a problem hiding this comment.
@sambible Good to add doc string which would describe functionality
airgun/entities/contentview_new.py
Outdated
| view = self.navigate_to(self, 'Edit', entity_name=entity_name) | ||
| return view.versions.table.read() | ||
|
|
||
| def check_if_blank_in_french(self): |
There was a problem hiding this comment.
Yes. This is just a read in french without any assertion.
airgun/views/common.py
Outdated
| Status = Dropdown( | ||
| locator='.//div[contains(@class, "All") or contains(@aria-haspopup="listbox")]' | ||
| ) | ||
| add_repo = PF4Button('OUIA-Generated-Button-secondary-2') |
There was a problem hiding this comment.
These "generated" locators may not be very stable, is there any alternative, like label?
airgun/views/common.py
Outdated
| add_repo = PF4Button('OUIA-Generated-Button-secondary-2') | ||
| # Need to add kebab menu | ||
| table = PatternflyTable( | ||
| component_id='OUIA-Generated-Table-4', |
There was a problem hiding this comment.
The same, can you use some better locator?
airgun/views/common.py
Outdated
| @@ -383,6 +386,71 @@ class add_tab(AddTab): | |||
| ) | |||
|
|
|||
|
|
|||
| class NewAddRemoveResourcesView(View): | |||
There was a problem hiding this comment.
Please add doc string for a class which would help to understand added functionality.
airgun/views/contentview_new.py
Outdated
| @@ -56,3 +88,148 @@ def is_displayed(self): | |||
| def after_fill(self, value): | |||
| """Ensure 'Create content view' button is enabled after filling out the required fields""" | |||
| self.submit.wait_displayed() | |||
|
|
|||
|
|
|||
| class ContentViewEditView(BaseLoggedInView): | |||
There was a problem hiding this comment.
Please add doc string for a class which would help to understand added functionality.
airgun/views/contentview_new.py
Outdated
| ) | ||
|
|
||
| @View.nested | ||
| class details(Tab): |
There was a problem hiding this comment.
Can we add short doc string here?
airgun/views/contentview_new.py
Outdated
| import_only = Switch(name='import_only_switch') | ||
|
|
||
| @View.nested | ||
| class versions(Tab): |
There was a problem hiding this comment.
Can we add short doc string here?
airgun/views/contentview_new.py
Outdated
| new_filter = Text(".//button[@ui-sref='content-view.yum.filters.new']") | ||
|
|
||
|
|
||
| class ContentViewVersionPublishView(BaseLoggedInView): |
There was a problem hiding this comment.
Please add doc string for a class which would help to understand added functionality.
airgun/views/contentview_new.py
Outdated
| ) | ||
|
|
||
|
|
||
| class NewContentViewVersionDetailsView(BaseLoggedInView): |
There was a problem hiding this comment.
Please add doc string for a class which would help to understand added functionality.
|
@sambible Could you update this PR? |
Airgun PR for a test automating a recent BZ.
This contains all the publish changes, which should be merged soon. The portions here that should be given attention to will be marked up with a comment by me. Thanks :)